fix: removed the fixed header size and margin

[balco0110]

Description:

Closes #1312 and #1558

Definition of Reviewable:

• E2E tests (features, a11y, bug fixes) are created/updated

• Stories (features, a11y) are created/updated
• relevant tickets are linked

[changeset-bot]

🦋 Changeset detected

Latest commit: 5be8316

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

🚀 Storybook has been deployed for branch fix_Unable-to-change-font-size-for-headline-in-sd-teaser-media

• View Storybook

[paulovareiro29]

Do you think this is a breaking change @smfonseca ? It will break the UI for some teasers

[smfonseca]

Do you think this is a breaking change @smfonseca ? It will break the UI for some teasers

Yes, I believe so.

@mariohamann left a suggestion to address this issue here.

In his example he's targeting directly the h4, but this will cascade to all other teasers. To make it more precise, I suggest adding a class to the headline slot and everything should work as expected.

Can you try it @balco0110?

[smfonseca]

This is a breaking change, do not merge.

[balco0110]

Do you think this is a breaking change @smfonseca ? It will break the UI for some teasers

Yes, I believe so.

@mariohamann left a suggestion to address this issue here.

In his example he's targeting directly the h4, but this will cascade to all other teasers. To make it more precise, I suggest adding a class to the headline slot and everything should work as expected.

Can you try it @balco0110?

i've pushed the code, added a class and removed the ::slotted([slot='headline']) part, in this way we are able to change the size of the text

[smfonseca]

i've pushed the code, added a class and removed the ::slotted([slot='headline']) part, in this way we are able to change the size of the text

But did you try to change the margin and font-size in the templates without removing ::slotted in css? I'm asking because if we go this route, I think it will mean lots of updates required to be done on users end.

[paulovareiro29]

Converting to draft to prevent from merging

[MartaPintoTeixeira]

Approving as it is not a visual change

[mariohamann]

I think this whole thing needs some re-consideration. Ideally it should work without a breaking change. Is this possible in any way?