feat: added footer to the templates - #3064
Conversation
github-project-automation
Bot
moved this to 📋 Backlog
in Solid Design System Project Board
GitHub Actions
Inactive
🦋 Changeset detectedLatest commit: 27b16c7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rahulsuvarna18
moved this from 📋 Backlog
to 👀 In review
in Solid Design System Project Board
|
🚀 Storybook has been deployed for branch |
GitHub Actions
Inactive
rahulsuvarna18
changed the title
rahulsuvarna18
changed the title
GitHub Actions
Inactive
There was a problem hiding this comment.
can you align the copy of the footer with the elements above?
In this case it should go more to the left so the headline is aligned with the headline above.
also please check responsive. it is not behaving properly in smaller screens
also when clicking on "Icon" under Audio it leads to an error FYI
|
FYI: I see a weird behavior on this PR. The footer on my local environment is at the bottom and loads properly. But the footer has a different behavior on storybook. |
|
Why can't we jsut put this in the defautl descriptions? I'm not even sure, why we need a fully designed footer here at all, when our whoel Storybook looks completely different to what we ahve in Figma. |
| footer.innerHTML = ` | ||
| <div class="template-global-footer__inner"> | ||
| <p class="sd-headline sd-headline--size-base m-0 !text-xl">${title}</p> | ||
| <div class="template-global-footer__links"> | ||
| ${linksMarkup} | ||
| </div> | ||
| </div> | ||
| `; | ||
| return footer; | ||
| }; | ||
|
|
||
| const renderTemplateFooter = (storyTitle, templateFooterConfig) => { | ||
| const tags = TEMPLATE_COMPONENT_MAP[storyTitle]; | ||
| if (!tags || tags.length === 0) return; | ||
|
|
||
| const targetRoot = document.getElementById('storybook-docs'); | ||
| if (!targetRoot) return; | ||
|
|
||
| const signature = `${storyTitle}::${tags.join('|')}`; | ||
| const existingFooter = document.getElementById(TEMPLATE_FOOTER_ID); | ||
|
|
||
| if ( | ||
| existingFooter && | ||
| existingFooter.parentElement === targetRoot && | ||
| existingFooter.dataset.componentSignature === signature | ||
| ) { | ||
| return; | ||
| } | ||
|
|
||
| if (existingFooter) { |
There was a problem hiding this comment.
Why can't we jsut put this in the defautl descriptions? I'm not even sure, why we need a fully designed footer here at all, when our whoel Storybook looks completely different to what we ahve in Figma.
This feels way too overengineered.
27d7cf0 to
ef312d1
Compare
GitHub Actions
Inactive
GitHub Actions
Inactive
6 participants
closes #1554
Description:
Definition of Reviewable: