fix: skip non-http(s) links in anchor click handler - #581
Open
aashish00021 wants to merge 1 commit into
Open
Conversation
handleAnchor only rejected links by origin, but `blob:` URLs inherit the page origin and slipped through, getting routed to a garbage pathname. Guard against any non-http(s) scheme (blob:, mailto:, tel:, data:, …). Fixes solidjs#382
🦋 Changeset detectedLatest commit: aa738bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #382
Problem
handleAnchordecides whether to intercept an<a>click for client-side routing via the same-origin check (url.origin === window.location.origin). Butblob:URLs inherit the page origin —new URL("blob:https://example.com/abc").origin === "https://example.com"— so they pass that check and get routed to a garbage pathname instead of being left for the browser to handle.Other non-http(s) schemes (
mailto:,tel:,data:,javascript:,file:,ws:/wss:) have originnullor a non-matching origin, so the existing origin check already rejects them — onlyblob:slips through.Fix
Guard against any non-http(s) scheme before the origin check:
blob:links are now skipped (previously routed); every other scheme is unchanged. A general non-http(s) guard is preferred overblob:-only — same size, but correct for any scheme that inherits the page origin (e.g.ws:/wss:).Test
Adds a regression test using a no-base-path router (the scenario where a
blob:link shares the page origin and slips past both the origin and path-prefix checks). Verified it fails without the guard (preventDefaultis called → the blob gets routed) and passes with it.tsctypecheck: clean@solidjs/routerpatch