ci: define the test dataset inline instead of fetching it from the registry - #49
Open
lukekim wants to merge 1 commit into
Open
ci: define the test dataset inline instead of fetching it from the registry#49lukekim wants to merge 1 commit into
lukekim wants to merge 1 commit into
Conversation
…gistry `spice add spiceai/quickstart` makes every run depend on the Spicepod registry, which is currently returning a body the CLI cannot unpack: Invalid argument: Failed to extract Spicepod archive: invalid Zip archive: Could not find EOCD Declaring the same dataset inline removes the dependency. Covers all four sites — three in build.yaml (including the PowerShell step) and one in publish.yaml. Verified locally: taxi_trips loads and is queryable within seconds. Mirrors spicepy#176.
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions workflows to avoid fetching the spiceai/quickstart Spicepod from the remote registry during CI, and instead appends an equivalent datasets: definition directly into the spicepod.yaml created by spice init.
Changes:
- Replaces
spice add spiceai/quickstartwith an inlinedatasets:block (S3 taxi trips parquet) in CI setup steps. - Applies the same inline dataset approach across all affected workflow sites (Unix + Windows in
build.yaml, and the publish pipeline inpublish.yaml).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/build.yaml | Replaces registry fetch with inline dataset config in multiple build/test jobs (including Windows). |
| .github/workflows/publish.yaml | Replaces registry fetch with inline dataset config prior to running publish tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| acceleration: | ||
| enabled: true | ||
| YAML | ||
| spiced &> spice.log & |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces
spice add spiceai/quickstartwith the same dataset declared inline. Four sites: three inbuild.yaml(including the PowerShell step) and one inpublish.yaml.Why
Every build job dies before Maven runs:
The Spicepod registry is returning a body the CLI can't unpack — reproducible off CI, so not a runner or network quirk. Pulling a test fixture from a remote registry means every PR depends on that service being up.
publish.yamlis included because it does the same fetch; leaving it would break the next release the same way.Mirrors spicepy#176, which is green.
Verification
taxi_tripsqueryable in ~6s, 2,964,624 rowsspice initemitsversion: v2