fix: replace self with globalThis#94
Merged
Merged
Conversation
Collaborator
|
@sgbeal FYI if this is something to fix upstream. Closing here as per the note in this repo's |
Collaborator
|
This isn't from upstream - it's an index.mjs file and we don't publish any files by that name. |
Collaborator
|
Oh no, I'm terribly sorry. I didn't look closely. Reopening and merging this PR. Apologies again! |
Collaborator
|
Released as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream package is setting
globalThis.sqlite3Worker1Promiser, henceself.sqlite3Worker1Promiserwill fail at runtime.