Implement token and orgs validation - #66
Conversation
I guess that there's something preventing it, but why can't you just check it immediately?
I'd go with |
you can't use docker-compose commands without creating workdir. |
Oh, right. So using |
|
yes. I provided 2 solutions for the problems in description:
|
|
But if we run docker, where do we get the name & version of the image? Is it possible to get it from docker-compose? |
|
I'm also OK moving the code from |
|
I also agree that it would be better if we could copy-paste the code in charge of the validation from I'd not delete that functionality from |
|
Using docker would require parsing of @se7entyse7en please confirm you are ok with it and I'll redo this PR. |
|
@smacker It's ok for me, I don't have a strong preference 👍 |
And yes, we're kind of in-rush now 😂 |
Fix: #59
Based on: #63
Only the last commit is new.
This PR fixes the issue according to the agreement but I have doubts it's the best way to validate stuff.
Current problems:
--no-depsdocker-compose already creates network and volumeI would better re-work it using simple http requests to github in the cli itself before starting messing with docker-compose. Or use docker instead of docker-compose. WDYT?