Skip to content

Use ansible_facts to get iso8601_basic_short#551

Merged
Alex-Welsh merged 1 commit into
mainfrom
use-ansible-facts
Jul 24, 2026
Merged

Use ansible_facts to get iso8601_basic_short#551
Alex-Welsh merged 1 commit into
mainfrom
use-ansible-facts

Conversation

@priteau

@priteau priteau commented Jul 24, 2026

Copy link
Copy Markdown
Member

Fixes the following deprecation warning:

[DEPRECATION WARNING]: INJECT_FACTS_AS_VARS default to True is deprecated, top-level facts will not be auto injected after the change. This feature will be removed from ansible-core version 2.24.

@priteau priteau self-assigned this Jul 24, 2026
@priteau
priteau requested a review from a team as a code owner July 24, 2026 11:18
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The development Pulp distribution version variable now derives its timestamp from ansible_facts.date_time.iso8601_basic_short, affecting downstream distribution names and base paths.

Changes

Pulp distribution version

Layer / File(s) Summary
Update distribution version fact source
ansible/inventory/group_vars/all/dev-pulp-repos
dev_pulp_distribution_version now uses the namespaced Ansible timestamp fact for its computed value.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately summarizes the change from ansible_date_time to ansible_facts for iso8601_basic_short.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch use-ansible-facts

Comment @coderabbitai help to get the list of available commands.

@Alex-Welsh
Alex-Welsh merged commit c595126 into main Jul 24, 2026
5 checks passed
@Alex-Welsh
Alex-Welsh deleted the use-ansible-facts branch July 24, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants