fix(iaas): print valid JSON/YAML output for list cmds#1365
Merged
j1n-o9r merged 41 commits intoMay 20, 2026
Merged
Conversation
j1n-o9r
marked this pull request as ready for review
April 13, 2026 15:07
Member
|
Missing: ... and maybe more. Please check carefully 😅 |
Contributor
Author
Sorry, I mistakenly understood the examples in the ticket as acceptance criteria and did not check the other resources. I will go through all and add the missing parts.😅 |
j1n-o9r
marked this pull request as draft
April 15, 2026 12:52
Member
|
@j1n-o9r We currently have a lot of merge conflicts here, could you please resolve them before one of the collegues starts with a review? 😅 |
j1n-o9r
force-pushed
the
fix/STACKITCLI-241-iaas-json-list-output
branch
3 times, most recently
from
April 22, 2026 10:35
eaa4afb to
9b8c40d
Compare
j1n-o9r
marked this pull request as ready for review
April 22, 2026 11:46
rubenhoenle
reviewed
Apr 22, 2026
rubenhoenle
reviewed
Apr 22, 2026
rubenhoenle
reviewed
Apr 22, 2026
rubenhoenle
reviewed
Apr 22, 2026
rubenhoenle
reviewed
Apr 22, 2026
rubenhoenle
reviewed
Apr 22, 2026
rubenhoenle
reviewed
Apr 22, 2026
rubenhoenle
reviewed
Apr 22, 2026
rubenhoenle
reviewed
Apr 22, 2026
rubenhoenle
reviewed
Apr 22, 2026
rubenhoenle
reviewed
Apr 22, 2026
rubenhoenle
reviewed
May 6, 2026
rubenhoenle
previously approved these changes
May 6, 2026
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
rubenhoenle
approved these changes
May 20, 2026
… any items via outputResult function instead of returning nil bluntly. adapted tests therefore.
Co-authored-by: Ruben Hönle <git@hoenle.xyz>
…o deal with nil values since it is required anyways
… string for not having to deal with nil values since it is required anyways
j1n-o9r
force-pushed
the
fix/STACKITCLI-241-iaas-json-list-output
branch
from
May 20, 2026 14:46
31576d1 to
1125d22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to STACKITCLI-241 / #893
Addition: I encountered a missing
--limit-flag within thestackit security-group listcommand and directly fixed this after consulting @marceljkTesting Instructions
Test for every list command that is changed (like f.e.
stackit server list) if the command returns the expected outputs like:stackit server list-> Expected: No servers found for project "xxx"stackit server list --output-format json-> Should output valid JSONstackit server list --output-format yaml-> Should output valid YAMLMock responses if testing against API is not possible.
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)