chore: add segment tracking (PLATFORM-2626) - #30
Merged
Conversation
johnsca
force-pushed
the
johnsca/2626/segment-tracking
branch
2 times, most recently
from
August 11, 2022 21:29
f96c6be to
88df52e
Compare
johnsca
marked this pull request as ready for review
August 11, 2022 22:12
johnsca
requested review from
a team and
fwereade
and removed request for
a team
August 11, 2022 22:12
Author
|
This is deployed to my sandbox for testing. |
johnsca
force-pushed
the
johnsca/2626/segment-tracking
branch
from
August 12, 2022 14:04
88df52e to
031f886
Compare
|
Hmm, the Segment key would preferably not be hard-coded, since we use a different one for internal vs customer envs. The Segment key is stored with the feature flags, and we use a TF override to set it differently for internal envs, for example: https://github.com/stacklet/imp-manifests/blob/main/qa/shared-infra/application-config/settings.auto.tfvars |
johnsca
force-pushed
the
johnsca/2626/segment-tracking
branch
9 times, most recently
from
August 15, 2022 17:28
6e14d7a to
820a51b
Compare
Author
|
Ok, key is now read from cookie and CSP issues have been resolved. |
johnsca
commented
Aug 15, 2022
johnsca
force-pushed
the
johnsca/2626/segment-tracking
branch
3 times, most recently
from
August 15, 2022 20:54
5dbcf85 to
b499917
Compare
Add Segment tracking code to get analytics data for Redash usage. Fixes: [PLATFORM-2626](https://stacklet.atlassian.net/browse/PLATFORM-2626)
johnsca
force-pushed
the
johnsca/2626/segment-tracking
branch
from
August 15, 2022 21:16
b499917 to
9679877
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Segment tracking analytics code to Redash HTML.
Implements PLATFORM-2626
Depends on https://github.com/stacklet/platform-ui/pull/1194