[4.x] Fix globals save event#8564
Merged
Merged
Conversation
Contributor
|
I can’t follow along with any of this I’m afraid. But will this event I’m using get deprecated? If so I can prepare. |
Contributor
No, the opposite Rob, it did break but this is the fix. |
Contributor
|
Cool. And it’ll stay in for the time being I guess. Thx |
Member
Author
|
Maybe in v5 it'll change. But only maybe. |
Contributor
|
Perfect. I'm sure by then I will have forgotten all about this so I can bug you all with the same questions again. |
Member
Author
|
Looking forward to it ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8559
Replaces #8561
Prior to #8343 when you save global variables in the CP, the GlobalSetSaved (etc) events would be dispatched. That PR made it so that when you save the variables, only the variable events got dispatched - logically. But that was a breaking change.
This PR makes it so that when you save the variables form, it'll still save the global set and dispatch the original events. This fixes the breaking change.