add support for WeAct "F411 8M HSE" variant and rename existing menu …#3035
Open
lehjr wants to merge 1 commit into
Open
add support for WeAct "F411 8M HSE" variant and rename existing menu …#3035lehjr wants to merge 1 commit into
lehjr wants to merge 1 commit into
Conversation
…entry to avoid confusion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…entry to avoid confusion
Pull Request template
Please, Make sure that your PR is not a duplicate.
Search among the Pull request before creating one.
IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.
Thanks for submitting a pull request.
Please provide enough information so that others can review your pull request:
Summary
This PR fixes/implements the following bugs/features
Adds support for WeAct F411 8M HSE variant as menu entry BlackPill F411CE (HSE 8Mhz). Original menu entry BlackPill F411CE renamed to BlackPill F411CE (HSE 25Mhz) to avoid confusion. F411 25M HSE 8M Flash was not added at this time, because the board is functionally equal to the existing supported device, just with the addition of the flash chip connected to SPI pins on PA4, PA5, PA6, and PA7.
Explain the motivation for making this change. What existing problem does the pull request solve?
Fixes device not working properly due to incompatible clock settings.
Validation
`#include <Arduino.h>
#define LED_PIN PC13
void setup() {
pinMode(LED_PIN, OUTPUT);
Serial.begin(115200);
while (!Serial) {
digitalWrite(LED_PIN, !digitalRead(LED_PIN));
delay(50);
}
}
void loop() {
Serial.println("USB CDC Working!");
}`
Code formatting
Closing issues
Fixes #3030