feat: LiveKitRoom, RoomAudioRenderer, PORTING.md, fix useIsMuted dep array bug, fix AudioTrack import path#1
Draft
OrcVole wants to merge 1 commit into
Draft
Conversation
…g, fix AudioTrack import, add PORTING.md Signed-off-by: LoudLemur <LoudLemur@users.noreply.gogs.demo.cloudron.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the missing foundation components and fixes two bugs found
while reading the existing code.
Added:
LiveKitRoom— root provider component, creates Room, managesconnection lifecycle, provides RoomContext to descendants
RoomAudioRenderer— renders hidden audio elements for all remoteparticipants, making them audible; uses existing useTracks and AudioTrack
PORTING.md— guide documenting the systematic React-to-Solid translationpatterns used in this library, including known gotchas
Fixed:
useIsMuted— was passing a dependency array as the second argument tocreateEffect, which Solid silently ignores. Replaced with createMemo so
the observable recreates reactively when the track reference changes.
AudioTrack— absolute import pathfrom 'src/signals'replaced withrelative
from '../../signals', which broke outside the dev environment.Happy to adjust anything based on feedback before this is merged.