Serialize the whole Frame in SimpleBenchmark.lightProtoSerialize - #16
Merged
merlimat merged 1 commit intoJul 30, 2026
Merged
Conversation
The benchmark filled a Frame (name + nested Point) but then wrote only the Point child, so the score never covered string serialization or the message envelope. Write the Frame like the protobuf counterpart does. New reference score: 164 ops/us (5 forks), vs ~170 for the old Point-only measurement - the array-compose write path makes the extra string+envelope work nearly free at this message size.
There was a problem hiding this comment.
Pull request overview
This PR fixes SimpleBenchmark.lightProtoSerialize so it benchmarks serializing the full Frame (including the string name and the message envelope), aligning it with what protobufSerialize measures and avoiding under-reporting regressions on those paths.
Changes:
- Serialize the full
Frameinstead of only the nestedPoint. - Update the JMH blackhole consumption to consume
frame(notp) to match the benchmarked object.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmark filled a Frame (name + nested Point) but then wrote only the Point child, so its score never covered string serialization or the message envelope — masking any regression on those paths. It now writes the whole Frame, matching what
protobufSerializemeasures.New reference score: 164 ops/µs (5 forks, ±3.3, JDK 26 / Apple M-series) vs ~170 for the old Point-only measurement — post-#12 the array-compose write makes the extra string+envelope work nearly free at this message size. protobuf-java counterpart: 28.8 ops/µs.