Update of CoDiPack and MeDiPack versions - #660
Merged
Merged
Conversation
…aced preaccumulation
…o update_codi_medi
Contributor
There was a problem hiding this comment.
These seem to be two very nice changes.
For the preaccumulation part, it looks good to me in any case. It will also make these routines easier to handle for non-AD developers as there is now no explicit index treatment in the AD source files anymore.
Same for the linear solver part, it simplifies the existing code a lot. Haven't been aware of the addToTape functionality, nice to learn about it now.
( - removed question that did not turn out to be expedient -)
| AD::FuncHelper->addUserData(SolverTol); | ||
| AD::FuncHelper->addUserData(MaxIter); | ||
| AD::FuncHelper->addUserData(config->GetKind_DiscAdj_Linear_Solver()); | ||
| AD::FuncHelper->addToTape(CSysSolve_b::Solve_b); |
talbring
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR updates codi and medi to the newest version. For externally differentiated functions and preaccumulation it now uses the interfaces provided by codi.
Related Work
This fixes #659.
PRs #650 and #653 should be merged in before (I will deal with this next week).
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.