Unsteady incompressible flow simulation with grid movement - #767
Conversation
…ual-time source term
…incompressible_ale
…incompressible_ale
…s are in thier positions.
… feature_incompressible_ale Conflicts: Common/src/config_structure.cpp Common/src/geometry_structure.cpp
Conflicts: Common/src/grid_movement_structure.cpp SU2_CFD/src/output_su2.cpp
|
@TobiKattmann Just test whether it works and gives the same results. The regression test should be added still with the old driver. I will adapt it accordingly. |
|
@cvencro & @talbring, Ok Testcase added using the old driver for serial and parallel regression. Residuals are identical for both drivers new & old (which should resolve your question @rsanfer, right?). In the Testcase .cfg the new driver options are commented out such that switching is a matter of (un)commenting lines. I put up a PR for the Testcase here su2code/TestCases#36 and if the regression tests pass I would merge the Testcase PR and revert the .travis.yml Update: su2code/Testcases is merged. So once my comment above concerning rotating frame is addressed this could be merged from my point of view. |
|
@TobiKattmann , thanks for the regression test. The unsteady grid motion simulations work with the updates to the ALE formulation. The rotating frame is solved as a steady problem with an added source term, an initial implementation of which has been implemented for the incompressible solver but that is still a work in progress and probably outside the scope of this PR as it stands, so I've added an error catch. |
|
Ok, I now believe that all issues/comments are addressed. |
economon
left a comment
economon
left a comment
There was a problem hiding this comment.
Thanks for the changed and test case! LGTM.
|
Yep, I think this is good to go. Thanks, @cvencro and @TobiKattmann!! |
talbring
changed the title
6 participants
Proposed Changes
This request enables unsteady incompressible flow simulation with grid movement. Changes are made as part of the collaboration with @economon and @TobiKattmann to expand the capabilities of the incompressible solver. Arbitrary Lagrangian-Eulerian formulation of the Low-Mach Navier-Stokes equations have been implemented which is suitable for both rigid grid motion and mesh deformation problems.
Regression test case to follow.
Related Work
#766
PR Checklist