Skip to content

Feat/451 chorefeature tell opencode what to do differently#471

Merged
sudo-tee merged 3 commits into
mainfrom
feat/451-chorefeature-tell-opencode-what-to-do-differently
Jul 20, 2026
Merged

Feat/451 chorefeature tell opencode what to do differently#471
sudo-tee merged 3 commits into
mainfrom
feat/451-chorefeature-tell-opencode-what-to-do-differently

Conversation

@sudo-tee

Copy link
Copy Markdown
Owner

This pr adds the possibility to Tell opencode whay you deny a permission.

This step is important because it does not interrupt subagents and they adapt to the comment you give.

image

To deny the request and stop you can use the the new Double esc

@jensenojs

jensenojs commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

sorry for being late, i will test and review now


here are some comment about life cycle

fix(permissions): bind feedback UI to request lifecycle

permission request              # authoritative state
└── interaction                 # scoped to request ID
    ├── feedback input
    ├── double-Esc timer
    ├── processing lock
    └── Dialog-owned Esc mapping

Removing a permission now closes its input, stops its timer, invalidates stale
callbacks, and removes its keymap. Responses are claimed once, cancelled input
leaves the request pending, and session cancellation uses the current reply
payload.

pr-466-local-fixes.patch


Actually, it might be nice if we could press 'S' to jump to the subagent's context when the subagent pops up this request. I may create another patch later. As always, you’re free to use or modify any of the patches as you see fit (Because to be honest, I haven't been paying much attention to these patches because of other matters)

图片

What do you think? We're starting to (or have already) developed interactions that go beyond TUI.

图片

pr-471-subagent-permission-session-action.patch

@sudo-tee

@jensenojs

Copy link
Copy Markdown
Collaborator

Furthermore, just thinking ahead—perhaps once the UI interactions have stabilized, we could use an agent to re-record all the interaction GIFs and give our README a fresh makeover.

Of course, this is still a long way off, because even getting an agent to record is quite a hassle, let alone the fact that none of these tasks have been completed yet

@sudo-tee

Copy link
Copy Markdown
Owner Author

@jensenojs I think the 1st patch is not the right one. The is the ole one I applied for another MR.

@jensenojs

Copy link
Copy Markdown
Collaborator

pr-471-permission-lifecycle-fix.patch

ah yes, this one @sudo-tee

@sudo-tee

Copy link
Copy Markdown
Owner Author

I've applied the patches,

I like it so far :) thanks.

I like the idea of creating new gifs from an agent :). IT might be tricky to get it right though.

@jensenojs

Copy link
Copy Markdown
Collaborator

I like the idea of creating new gifs from an agent :). IT might be tricky to get it right though.

When that day finally comes, I'll handle the workflow for automatically generating GIFs.

@sudo-tee
sudo-tee merged commit 3b10019 into main Jul 20, 2026
10 checks passed
disrupted pushed a commit to disrupted/opencode-native.nvim that referenced this pull request Jul 23, 2026
)

* feat(permissions): allow providing feedback when rejecting permission

* feat(permissions): double-esc to deny without feedback

* refactor(permission_window): replace module-level deny state with interaction object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[chore/feature] : Tell OpenCode what to do differently

2 participants