Skip to content

build: Specify install directories in terms of libdir #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marv wants to merge 2 commits into from
Closed

build: Specify install directories in terms of libdir #106

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0caf39c
build: Install protocol handlers into libexec directory
marv Nov 2, 2017
32e8c5d
build: Obtain udev directory from pkg-config
marv Nov 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,10 @@ endif

prefixdir = get_option('prefix')
bindir = join_paths(prefixdir, get_option('bindir'))
libexecdir = join_paths(prefixdir, get_option('libexecdir'))

@igor-raits igor-raits Nov 5, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as I said, not going to work. see #37

@fsateler fsateler Nov 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explanation there is this:

/usr/lib is really where shared libraries, as well as binaries of the primary arch belong. And /usr/lib64 is where the secondary arch shared libs belong.

Not really. At least on debian-based systems, it is preferred to install shared libraries under /usr/lib/$triplet, where $triplet is a gnu triplet (eg, x86_64-linux-gnu). This allows co-installing libraries from multiple architectures. But helper programs normally do not need to exist for any architecture but the primary, and thus do not benefit from this scheme. In fact, it can introduce problems, if it can ever happen that a program configured for x86_64-linux-gnu runs with the helper binaries configured for i386-linux-gnu, then it won't be found. Therefore, programs may be installled directly under /usr/lib/$package.

This can be seen in eg, systemd, where helper binaries live in /lib/systemd, but the shared library lives in /lib/x86_64-linux-gnu/libsystemd.so.0.

Casync does not currently ship any libraries, but according to the initial announcement it is planned to ship one, so I think it makes sense to decouple helper programs from the shared libraries.

datadir = join_paths(prefixdir, get_option('datadir'))
docdir = join_paths(datadir, 'doc/casync')
protocoldir = join_paths(prefixdir, 'lib/casync/protocols')
protocoldir = join_paths(libexecdir, 'casync/protocols')
conf.set_quoted('CASYNC_PROTOCOL_PATH', protocoldir)

liblzma = dependency('liblzma',
Expand Down Expand Up @@ -141,8 +142,8 @@ subdir('test')

includes = include_directories('src')

udevlibexecdir = join_paths(prefixdir, 'lib/udev')
udevrulesdir = join_paths(udevlibexecdir, 'rules.d')
udevdir = dependency('udev').get_pkgconfig_variable('udevdir')
udevrulesdir = join_paths(udevdir, 'rules.d')

subdir('doc')

Expand Down