Firmware debugging fixes and updates. - #1208
Merged
Merged
Conversation
plbossart
reviewed
Sep 12, 2019
plbossart
left a comment
plbossart
left a comment
Member
There was a problem hiding this comment.
looks mostly good to me, couple of questions below:
plbossart
requested changes
Sep 13, 2019
plbossart
left a comment
plbossart
left a comment
Member
There was a problem hiding this comment.
can you fix checkpatch warnings with spaces/tabs? less work for me...
Allow other non core.c users for debug module params and also make the prefix consistent. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
FW mailbox offset was not set before use and HDR size was not validated. Fix this. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
lgirdwood
force-pushed
the
lrg/topic/debug
branch
from
September 16, 2019 13:59
7231b22 to
c8f4b3f
Compare
Member
Author
|
@plbossart updated, I also had to add a patch for minor module param fixes. It seems we had split the bits across core.c and sof-priv.h |
Add config option to prevent DSP entering D3 after any FW exception. This can then be used to dump FW context for debug. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Helps with FW debug as it provides DSP IPC processing context. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
lgirdwood
force-pushed
the
lrg/topic/debug
branch
from
September 16, 2019 14:04
c8f4b3f to
724701f
Compare
plbossart
approved these changes
Sep 16, 2019
plbossart
left a comment
plbossart
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for the change of the module parameter, this is much better now.
Member
|
need second approver btw. |
ranj063
approved these changes
Sep 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a kernel oops if DSP stack dump is corrupted and adds support for improved FW exception debugging.