ASoC:SOF:skl:enable the core and get the ROM init. V2 by zhuyingjiang · Pull Request #132 · thesofproject/linux

zhuyingjiang · 2018-09-14T06:36:40Z

enable the skl core
get the ROM int

Signed-off-by: Zhu Yingjiang yingjiang.zhu@linux.intel.com

lgirdwood · 2018-09-14T12:32:37Z

ok, so this code is confusing as if ROM status is 0 we return 0 ( and 0 globally means success within the kernel) ?? but if ROM status is good we return -EIO ??

The debug info is error, removed

lgirdwood · 2018-09-14T12:32:58Z

This is debug, it must be removed before merge.

zhuyingjiang · 2018-09-14T15:37:07Z

@lgirdwood

lgirdwood

Some more minor updates needed.

lgirdwood · 2018-09-15T20:15:33Z

This should be if (ret < 0) since 0 is always success. This check should also be in the else {} block above.

Oh, this should be removed, since prepare is not here.

lgirdwood · 2018-09-15T20:58:56Z

snd_sof_dsp_register_poll only return 0 on success.

OK, will change.

lgirdwood · 2018-09-15T21:00:50Z

you should just return here.

OK, will change

zhuyingjiang

changed according to the comments.

zhuyingjiang · 2018-09-16T13:02:59Z

Oh, this should be removed, since prepare is not here.

zhuyingjiang · 2018-09-16T13:08:03Z

OK, will change

zhuyingjiang · 2018-09-16T13:08:23Z

OK, will change.

zhuyingjiang · 2018-09-16T13:42:42Z

@lgirdwood changed according to the comments.

lgirdwood

Just fix return code checking and it should be good to merge

lgirdwood · 2018-09-16T20:49:17Z

ret should be checked here in this {} block and if < 0 should power off core and return ret

OK, if (ret<0) goto err;

lgirdwood · 2018-09-16T20:51:13Z

always use if (ret < 0) for error checking as some posix/kernel APIs may also return a positive integer on success

OK, make all the fail return, if(ret<0) goto err;

lgirdwood · 2018-09-16T20:52:58Z

Good check!

zhuyingjiang

OK, the return value changed.

zhuyingjiang · 2018-09-17T02:56:40Z

OK, if (ret<0) goto err;

zhuyingjiang · 2018-09-17T02:57:18Z

OK, make all the fail return, if(ret<0) goto err;

zhuyingjiang · 2018-09-17T02:57:40Z

Good check!

zhuyingjiang · 2018-09-17T06:46:00Z

@lgirdwood the return value changed.

lgirdwood

Just one line to delete.

lgirdwood · 2018-09-17T09:53:53Z

No need to change the value of ret here, otherwise the meaning will be lost further up the stack. So best remove this line.

1. enable the skl core 2. get the ROM int Signed-off-by: Zhu Yingjiang <yingjiang.zhu@linux.intel.com>

zhuyingjiang · 2018-09-17T11:52:17Z

@lgirdwood removed.

zhuyingjiang force-pushed the topic/sof-dev-yjzhu branch from 117fed5 to 43663ba Compare September 14, 2018 06:41

zhuyingjiang requested a review from lgirdwood September 14, 2018 07:26

lgirdwood requested changes Sep 14, 2018

View reviewed changes

zhuyingjiang force-pushed the topic/sof-dev-yjzhu branch from 43663ba to 25124a1 Compare September 14, 2018 15:33

lgirdwood requested changes Sep 15, 2018

View reviewed changes

zhuyingjiang force-pushed the topic/sof-dev-yjzhu branch from 25124a1 to 704569b Compare September 16, 2018 13:38

zhuyingjiang commented Sep 16, 2018

View reviewed changes

lgirdwood requested changes Sep 16, 2018

View reviewed changes

zhuyingjiang force-pushed the topic/sof-dev-yjzhu branch from 704569b to 0af4ef8 Compare September 17, 2018 02:56

zhuyingjiang commented Sep 17, 2018

View reviewed changes

lgirdwood requested changes Sep 17, 2018

View reviewed changes

ASoC:SOF:skl:enable the core and get the ROM init

d71d6c0

1. enable the skl core 2. get the ROM int Signed-off-by: Zhu Yingjiang <yingjiang.zhu@linux.intel.com>

zhuyingjiang force-pushed the topic/sof-dev-yjzhu branch from 0af4ef8 to d71d6c0 Compare September 17, 2018 11:51

lgirdwood merged commit a84d54b into thesofproject:topic/sof-dev Sep 17, 2018

Uh oh!

Conversation

zhuyingjiang commented Sep 14, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhuyingjiang commented Sep 14, 2018

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhuyingjiang left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhuyingjiang commented Sep 16, 2018

Uh oh!

lgirdwood left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhuyingjiang left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhuyingjiang commented Sep 17, 2018

Uh oh!

lgirdwood left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhuyingjiang commented Sep 17, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

lgirdwood left a comment •

edited

Loading