[SQUASHME]ASoC: sof: topology: fix memleak when errror happen#40
Merged
Conversation
Add kfree function when other error happens. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
Collaborator
|
@plbossart @xiulipan this looks good. One thing to add is freeing scontrol in control_unload too. |
Author
|
@ranj063 @plbossart |
Member
|
@ranj063 do you have any issues if we take this first if there are no blatant conflicts? I prefer to squash issues first rather than keep old bugs alive. |
Collaborator
|
@plbossart yes, please go ahead. This looks good. It will not affect my work. |
plbossart
approved these changes
Jul 21, 2018
plbossart
left a comment
plbossart
left a comment
Member
There was a problem hiding this comment.
@lgirdwood probably need to apply/squash this patch for upstream as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add kfree function when other error happens.
Signed-off-by: Pan Xiuli xiuli.pan@linux.intel.com