AMD SOF based generic SoundWire machine driver - #5068
Merged
plbossart merged 31 commits intoJul 5, 2024
Merged
Conversation
vijendarmukunda
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
plbossart,
ranj063 and
ujfalusi
as code owners
June 18, 2024 06:28
vijendarmukunda
force-pushed
the
topic/sof-dev
branch
from
June 21, 2024 08:20
cf9e1a3 to
d897ebf
Compare
plbossart
reviewed
Jun 21, 2024
plbossart
left a comment
plbossart
left a comment
Member
There was a problem hiding this comment.
Looks pretty good to me @vijendarmukunda
I only have minor comments, time for others to comment as well. @bardliao @charleskeepax on your mark, set, go!
vijendarmukunda
force-pushed
the
topic/sof-dev
branch
from
June 24, 2024 13:55
d897ebf to
8fcde28
Compare
plbossart
requested changes
Jun 25, 2024
plbossart
left a comment
plbossart
left a comment
Member
There was a problem hiding this comment.
The last patch needs a bit more work IMHO, still too much duplication of complicated code that we don't want to fork.
The rest looks ok, thanks!
Member
|
SOFCI TEST |
bardliao
reviewed
Jun 25, 2024
vijendarmukunda
force-pushed
the
topic/sof-dev
branch
from
June 25, 2024 10:04
8fcde28 to
96ccec8
Compare
Author
Agreed. We are going to refactor the code . We need to add support for newer ACP variants. We are going to add support for legacy (NO DSP) machine driver support where we are going to refactor existing code. |
To make it generic, rename structure 'sof_sdw_codec_info' as 'asoc_sdw_codec_info' and 'sof_sdw_dai_info' as 'asoc_sdw_dai_info'. These structures will be moved to common header file so that it can be used by other platform machine driver. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Rename sof quirk macros, dai type and dai link macros with "SOC_SDW" tag. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Rename Soundwire generic machine driver soc ops with tag "asoc". Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Rename SoundWire codec helper functions with "asoc_sdw" tag. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Rename maxim codec part id macros. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Rename 'ignore_pch_dmic' variable name as 'ignore_internal_dmic'. This variable will be moved to common header file and will be used by other platform machine driver code. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Move Intel SoundWire generic machine driver soc ops to common place so that it can be used by other platform machine driver. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Move intel generic SoundWire machine driver common structures to soc_sdw_utils.h file. These structures will be used in other platform SoundWire machine driver code. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Move below Intel SoundWire machine driver helper functions to soc_sdw_utils.c file so that it can be used by other platform machine driver. - asoc_sdw_is_unique_device() - asoc_sdw_get_codec_name() Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Move generic dmic codec helper function implementation to sdw_utils folder so that this function can be used by other platform machine drivers. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Move rtk SoundWire dmic helper functions implementation to sdw_utils folder to make it generic. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Move RT712 SDCA codec helper file to sdw_utils folder so that these helper functions can be used by other platform machine drivers. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Move RT722 SDCA codec helper file to sdw_utils folder to make it generic. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Split intel generic SoundWire machine driver private data into two structures. One structure is generic one which can be used by other platform machine driver and the other one is intel specific one. Move generic machine driver private data to soc_sdw_utils.h. Define a void pointer in generic machine driver private data structure and assign the vendor specific structure in mc_probe() call. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Move rt5682 sdw codec helper function to common place holder to make it generic. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch series is rebase version of PR#5034