New scripts/requirements-lax.txt with '>=' instead of '==' - #231
Merged
Conversation
This reverts and replaces commit 26d3862 that replaced the "m4" Pygment formatter by no code-block:: argument at all. The argument was not optional in Sphinx versions before 2.0 and they produce this giant warning that includes the entire code-block. Use simple, no-op Pygment "text" instead. sof-docs/algos/demux/demux.rst:62: WARNING: Error in "code-block" directive: 1 argument(s) required, 0 supplied. .. code-block:: # pipeline_id, channels, matrix_rows define(matrix1, `ROUTE_MATRIX(PIPELINE_ID, 2, `BITS_TO_BYTE(1, 0, 0 ,0 ,0 ,0 ,0 ,0)', `BITS_TO_BYTE(0, 1, 0 ,0 ,0 ,0 ,0 ,0)', etc. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Avoids hardcoding and virtualenvs. See problem statement and discussion in PR thesofproject#198 and extensive comments in the new file itself. Successfully tested with stock, "apt" versions on Ubuntu 18.04 LTS and a totally empty 'pip3 list --local' Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
marked this pull request as ready for review
April 17, 2020 07:32
marc-hb
requested review from
deb-intel,
intelkevinputnam and
lgirdwood
as code owners
April 17, 2020 07:32
marc-hb
requested review from
dbaluta,
jajanusz,
mmaka1,
paulstelian97 and
xiulipan
April 17, 2020 07:36
Collaborator
Author
lgirdwood
approved these changes
Apr 17, 2020
| 2 routing matrices and a demux component: | ||
|
|
||
| .. code-block:: | ||
| .. code-block:: text |
Collaborator
There was a problem hiding this comment.
Another good option for these is ..code-block:: none
Collaborator
Author
Cleaned up and submitted in PR #237 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids hardcoding and virtualenvs.
See problem statement and discussion in PR #198 and extensive comments
in the new file itself.
Successfully tested with stock, "apt" versions on Ubuntu 18.04 LTS and
a totally empty 'pip3 list --local'
Signed-off-by: Marc Herbert marc.herbert@intel.com