lib: opt.sh: remove useless cmd.txt code and shellcheck cleanup - #206
lib: opt.sh: remove useless cmd.txt code and shellcheck cleanup#206Bin-QA wants to merge 1 commit into
Conversation
|
Verify for the CI system, without script break |
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
Thanks, removing code is always worth more than adding new code! Less maintenance. Can you explain in the commit message and summarize in the commit Subject: one-line why this code was not useful? Anymore? Removing code is the bigger change and should be first in the commit message. Shellchecks fixes are great too but they are secondary and should be second.
marc-hb
changed the title
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
Please run checkpatch locally first before submitting, it will save a lot of code review time and delays.
f7c668c to
9e88d29
Compare
1. remove useless code for record cmdline into cmd.txt file This file design for record full command line but it is none to use it and it also have some issue when full paste command it too complex to fix full command line issue so remove it 2. fix shell check error for opt.sh 3. move git_path as SCRIPT_HOME into lib.sh Signed-off-by: Wu, BinX <binx.wu@intel.com>
|
too long time for this PR |
PR #222 correct? |
Yes |
3 participants
Signed-off-by: Wu, BinX binx.wu@intel.com