verify-firmware-load: add SOF_VERSION_CHECK variable - #853
Conversation
when using SOF_VERSION_CHECK=none, the verify-sof-version-check.sh script is skipped. This enables us to pass the kmod load/unload tests with IPC4, e.g with SOF_VERSION_CHECK=none SOF_LOGGING=none TPLG=/lib/firmware/intel/avs-tplg/sof-hda-generic.tplg ~/sof-test/test-case/check-kmod-load-unload-after-playback.sh Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
|
|
||
| setup_kernel_check_point | ||
|
|
||
| ( set +x |
There was a problem hiding this comment.
i copy-pasted it from your SOF_LOGGING work :-)
I have no idea what this does.
There was a problem hiding this comment.
set -x enables tracing/"logging". This is useful to log complex commands (with many parameters) without copy/paste.
set +x turns it off, see help set and https://www.gnu.org/software/bash/manual/html_node/The-Set-Builtin.html
The ( set +x ... ) subshell makes the set +x change local to it, not affecting the current / parent shell. Similar to { int i; ... } in C.
| ( set +x | ||
| if [ "$SOF_VERSION_CHECK" = 'none' ]; then | ||
| printf '$''SOF_VERSION_CHECK=none, skipping verify-sof-firmware-load.sh\n' | ||
| exit 2 |
There was a problem hiding this comment.
There is a much more readable skip_test function now.
There was a problem hiding this comment.
Is this what you had in mind?
if [ "$SOF_VERSION_CHECK" = 'none' ]; then
skip_test ''SOF_VERSION_CHECK=none"
fi
There was a problem hiding this comment.
Yes this should work and be equivalent.
| dlogi "checking if firmware is loaded successfully" | ||
| "$(dirname "${BASH_SOURCE[0]}")"/verify-sof-firmware-load.sh || | ||
| die "Failed to load firmware after module insertion" | ||
| ( set +x |
| ( set +x | ||
| if [ "$SOF_VERSION_CHECK" = 'none' ]; then | ||
| printf '$''SOF_VERSION_CHECK=none, skipping verify-sof-firmware-load.sh\n' | ||
| dlogi "==== firmware boot check skipped: $idx of $loop_cnt ====" |
There was a problem hiding this comment.
For consistency:
| dlogi "==== firmware boot check skipped: $idx of $loop_cnt ====" | |
| dlogi "==== firmware load check skipped: $idx of $loop_cnt ====" |
(and again below)
|
Rather than adding yet another variable I'd rather make this test simply pass with IPC4. This test was buggy anyway!!! See fix submitted in #855 |
2 participants
when using SOF_VERSION_CHECK=none, the verify-sof-version-check.sh
script is skipped.
This enables us to pass the kmod load/unload tests with IPC4, e.g with
SOF_VERSION_CHECK=none SOF_LOGGING=none TPLG=/lib/firmware/intel/avs-tplg/sof-hda-generic.tplg ~/sof-test/test-case/check-kmod-load-unload-after-playback.sh
Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com