There is build error for the archieved tar ball

[ewanglong]

1. download https://github.com/thesofproject/sof/archive/v1.2.tar.gz;
   2)unzip it in local and follow the building steps:
   $autogen.sh
   $./configure --enable-rimage
   $make
   will meet below error:
   man_apl.c:64:30: error: expected expression before ‘,’ token
   .major_version = SOF_MAJOR,
   ^

It was due to there is no git tag by directly tar ball building. May refer to below script from version.sh.
GIT_TAG=git describe --abbrev=4 2>/dev/null

So need specify or get the correct version under tar ball building environment.

[xiulipan]

@ewanglong
Yes, this bug is related to the git tag.
We will have some fix for it. We may not rely on the git tag anymore to avoid this problem.

[lgirdwood]

@xiulipan make dist should take the git tag and write it to a file for the version script to read and generate SOF_MAJOR etc.

[xiulipan]

@lgirdwood
I will check that. Maybe our script will try to regenerate the version and overwrite it?

[zhuyingjiang]

PR 597 #597 is submit to solve this problem, we use the .tarball-version file to get the version number if the .git folder can't be found. So every time anyone who make a tag should also change the version number in the .tarball-version file. Now the .tarball-version file should be upstreamed.

[zhuyingjiang]

PR597 #597 solved this problem, so close this issue.

[jajanusz]

#605 reverted it, I described there what should be done.
One more thing tho:
I made tarball with ./autogen.sh && ./configure --enable-rimage && make dist and it had .tarball-version inside it. However https://github.com/thesofproject/sof/archive/v1.2.tar.gz doesn't have it, you should look into how published tarballs are made because they look wrong

[zhuyingjiang]

@jajanusz My PR is submit to master branch and only the release after that will take effect. v1.2.tar.gz is from another branch surely will not have .tarball-version in it.

[zhuyingjiang]

@lgirdwood this is a issue of " build error for the archived tar ball" or a issue for "make dist", I think they are 2 issues. My PR #597 resolved the "build error for the archived tar ball". while make dist is another issue while relating to this

[zhuyingjiang]

@jajanusz @lgirdwood
A little more describe on this: we get version number from git tag, and compile need this version number for compiling. but if we release tarball with .git folder not included, the compile will fail for less the version number. My fix #597 is to resolve this.
As for why https://github.com/thesofproject/sof/archive/v1.2.tar.gz can't work. I think:
1: the release have not include my patch for they are not in the same branch. How should it work?
2: The https://github.com/thesofproject/sof/archive/v1.2.tar.gz can't work is because the step for generate the tar ball is error, the "make dist" have excluded all the scripts even without "autogen.sh". the tarball in the github is not the same with the output of "make dist", someone else must have changed on that.