Move code from multiple headers to .c files - #1007
Closed
lyakh wants to merge 1 commit into
Closed
Conversation
src/arch/xtensa/include/arch/task.h, src/include/sof/wait.h, and src/include/sof/panic.h contained functions, too big for inlining. Move them out to .c files. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Contributor
|
@lyakh No problem. I like this refactor (hiding implementations) so it's worth the effort |
jajanusz
suggested changes
Feb 14, 2019
jajanusz
left a comment
jajanusz
left a comment
Contributor
There was a problem hiding this comment.
Please apply convention of commit titles format like topic: changes, for example arch: refactor something, if you cannot find a good title maybe you should split changes into multiple commits - it also makes git bisect better when you have fine grained changes
Collaborator
Author
|
the commit has been split and moved over to #1005 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I bet this will fail cmocka again, and I might need help with that again...