topology: add more buffering to media pipe after src - #1478
Merged
Conversation
Currently we have 1.5 times buffering after SRC in media pipeline. This will not work for S24 or S32 playback as SRC will use the bigger buffers with non-integer sample rate conversions as 44.1kHz to 48kHz. So add as big buffer after SRC as before it. Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com>
juimonen
requested review from
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
May 27, 2019 13:23
lgirdwood
approved these changes
May 27, 2019
jajanusz
approved these changes
May 29, 2019
Contributor
|
@zrombel CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we have 1.5 times buffering after SRC in media pipeline. This
will not work for S24 or S32 playback as SRC will use the bigger buffers
with non-integer sample rate conversions as 44.1kHz to 48kHz. So add as
big buffer after SRC as before it.
Signed-off-by: Jaska Uimonen jaska.uimonen@intel.com