abi: user: make userspce ABI usage more obvious - #1517
Merged
Conversation
This tool is generic and can be used with any binary kcontrol to send data to/from components at runtime. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Dump the ABI header from source CSV or DSP data. This will make it obvious if there are any ABI differences. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Add more comments describing usage of header from userspace. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
lgirdwood
requested review from
a team,
jajanusz,
lbetlej,
mmaka1,
plbossart and
singalsu
as code owners
June 4, 2019 13:53
singalsu
reviewed
Jun 4, 2019
| @@ -9,29 +9,24 @@ | |||
| #include <stdint.h> | |||
| #include <errno.h> | |||
| #include <alsa/asoundlib.h> | |||
|
|
|||
| #define SOF_CTRL_CMD_BINARY 3 /* TODO: From uapi ipc */ | |||
Collaborator
There was a problem hiding this comment.
Good, thanks for cleaning up this!
Contributor
|
@lgirdwood |
tlauda
approved these changes
Jun 5, 2019
jajanusz
approved these changes
Jun 5, 2019
Member
Author
|
@lgirdwood this change doesn't affect FW CI. It's good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clear the fog around usage of ABI header for userspace applications. Also make the sof-eqctl generic as there is nothing that tightly coupes it to equalizers (except strings).