Skip to content

audio: dcblock: Fix doxygen error for dcblock.h - #2746

Merged
lgirdwood merged 1 commit into
thesofproject:masterfrom
sebcarlucci:dcblock/patch-doxygen-issue
Apr 9, 2020
Merged

audio: dcblock: Fix doxygen error for dcblock.h#2746
lgirdwood merged 1 commit into
thesofproject:masterfrom
sebcarlucci:dcblock/patch-doxygen-issue

Conversation

@sebcarlucci

Copy link
Copy Markdown
Contributor

This commit fixes a doxygen issue caused by a mismatch between
dcblock_find_func()'s declaration and its corresponding comment block.

Signed-off-by: Sebastiano Carlucci scarlucci@google.com

This commit fixes a doxygen issue caused by a mismatch between
dcblock_find_func()'s declaration and its corresponding comment block.

Signed-off-by: Sebastiano Carlucci <scarlucci@google.com>

@monocodus monocodus Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is autogenerated code-style review, all good, approving

@sebcarlucci

Copy link
Copy Markdown
Contributor Author

FYI @marc-hb

@marc-hb
marc-hb self-requested a review April 8, 2020 18:25

@marc-hb marc-hb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

travis-ci/pr is now all green again, even after I added doxygen in PR #2741 and "broke it" \o/
Thanks @sebcarlucci for the very prompt fix.

@plbossart (or any other in timezone maintainer) can we expedite this? It's a pure doxygen fix...

@marc-hb

marc-hb commented Apr 9, 2020

Copy link
Copy Markdown
Collaborator

Internal Intel CI System/merge/codecheck https://quickbuild.igk.intel.com/build/4940533 completed successfully after 2 minutes. The notification was apparently lost.

The pr-device-test GLK_BOB_DA7219 failure is obviously unrelated as this is just a doxygen fix.

@lgirdwood

Copy link
Copy Markdown
Member

@zrombel we are seeing lots of codecheck pending as reported here by @marc-hb . Any insights ?

@lgirdwood
lgirdwood merged commit 4223d87 into thesofproject:master Apr 9, 2020
@zrombel

zrombel commented Apr 9, 2020

Copy link
Copy Markdown

@lgirdwood There is a lack of finish notification step in QB configuration. I will take care of that right away.

@zrombel

zrombel commented Apr 9, 2020

Copy link
Copy Markdown

Just looked into it more, and seems that code check on QB is still work in progress, will try to push it to finish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants