cmake: do not download submodules when BUILD_UNIT_TESTS or CONFIG_LIBRARY - #4777
Merged
Conversation
Faster CI. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
marked this pull request as ready for review
September 16, 2021 23:48
marc-hb
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
September 16, 2021 23:48
marc-hb
marked this pull request as draft
September 17, 2021 05:40
Fixes 177d9bd ("cmake: defer the rimage build until it's actually needed.") that corrected the rimage dependency but forgot about the include. This allows building the testbench without fetching rimage. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Faster CI and will catch any accidental dependency sneaking in. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
changed the title
marc-hb
marked this pull request as ready for review
September 17, 2021 05:54
marc-hb
requested review from
aiChaoSONG,
dcpleung,
ktrzcinx,
kv2019i and
singalsu
September 17, 2021 05:56
lgirdwood
approved these changes
Sep 17, 2021
Member
|
CI failures unrelated to this, lets retry. |
Member
|
SOFCI TEST |
kv2019i
approved these changes
Sep 17, 2021
Member
|
CI showing what looks like network issue unrelated to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Faster CI, no dependency accidentally sneaking in
Signed-off-by: Marc Herbert marc.herbert@intel.com