tools: make sof_ri_info.py a usable library that can be imported - #6382
Merged
Conversation
2 small changes required: - Stop calling sys.exit(1) in case of error not to exit the importer - Change EraseVars() to return the checksum value instead of printing it. Move the print() to the main() function This is required by the new sof-bin tests that compare signed with unsigned binaries; submitted in thesofproject/sof-bin#105 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
force-pushed
the
sof-ri-info-lib
branch
from
October 7, 2022 08:19
ed0c5ce to
98298eb
Compare
marc-hb
marked this pull request as ready for review
October 7, 2022 08:23
marc-hb
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
October 7, 2022 08:23
marc-hb
requested review from
abonislawski,
greg-intel,
juimonen,
kv2019i and
mengdonglin
October 7, 2022 14:21
Collaborator
Author
|
The fix for the unrelated sparse error in https://github.com/thesofproject/sof/actions/runs/3203291899/jobs/5233213507 has been submitted in #6370 |
lgirdwood
approved these changes
Oct 10, 2022
lgirdwood
left a comment
lgirdwood
left a comment
Member
There was a problem hiding this comment.
@aborisovich any comments ?
aiChaoSONG
approved these changes
Oct 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 small changes required:
This is required by the new sof-bin tests that compare signed with unsigned binaries; submitted in
thesofproject/sof-bin#105
Signed-off-by: Marc Herbert marc.herbert@intel.com