Revert "hda: chain dma: cancel task before freeing it" - #7189
Merged
Conversation
lgirdwood
approved these changes
Mar 2, 2023
jsarha
marked this pull request as ready for review
March 2, 2023 13:13
Collaborator
|
SOFCI TEST |
jsarha
force-pushed
the
revert_chain_dma_cancel_fix
branch
from
March 2, 2023 13:16
fe521d1 to
cebd788
Compare
makarukp
approved these changes
Mar 2, 2023
juimonen
approved these changes
Mar 2, 2023
Contributor
Author
|
The CI was successful: https://sof-ci.01.org/sofpr/PR7189/build4252/devicetest/index.html I'll fix the checkpatch issue (re-wrap the commit message). |
jsarha
force-pushed
the
revert_chain_dma_cancel_fix
branch
from
March 2, 2023 17:50
cebd788 to
769e588
Compare
Contributor
Author
|
Only the commit message was changed. |
lgirdwood
approved these changes
Mar 2, 2023
Member
|
SOFCI TEST |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was not the correct fix for the ll timer free crash issue. Now that the correct fix[1] is found and merged, this workaround can be removed.
[1] b3a808a "chain-dma: fix scheduling exception"
This reverts commit 60e9e97.
This should not be merged before #7138 is in.