cache: remove buffer_acquire/release part 5 - #8220
Merged
Merged
Conversation
remove buffer ops from drc module this is a continuation of changes from commit 4a03699 Signed-off-by: Tobiasz Dryjanski <tobiaszx.dryjanski@intel.com>
remove buffer ops from google_hotword_detect module this is a continuation of changes from commit 4a03699 Signed-off-by: Tobiasz Dryjanski <tobiaszx.dryjanski@intel.com>
tobonex
marked this pull request as ready for review
September 19, 2023 11:32
btian1
approved these changes
Sep 20, 2023
lyakh
reviewed
Sep 20, 2023
| buffer_c = buffer_acquire(cd->aec_reference); | ||
|
|
||
| ref = audio_stream_get_rptr(&buffer_c->stream); | ||
| ref = audio_stream_get_rptr(&cd->aec_reference->stream); |
Collaborator
There was a problem hiding this comment.
maybe keep a pointer for this too - it's a .copy()
Contributor
Author
There was a problem hiding this comment.
kept buffer_c but changed name to just buffer
tobonex
force-pushed
the
buffer_acquire_removal_5
branch
from
September 20, 2023 15:49
f4523b1 to
f53ed83
Compare
remove buffer ops from google_rtc_audio_processing module this is a continuation of changes from commit 4a03699 Signed-off-by: Tobiasz Dryjanski <tobiaszx.dryjanski@intel.com>
remove buffer ops from cadence.c this is a continuation of changes from commit 4a03699 Signed-off-by: Tobiasz Dryjanski <tobiaszx.dryjanski@intel.com>
remove buffer ops from dts.c this is a continuation of changes from commit 4a03699 Signed-off-by: Tobiasz Dryjanski <tobiaszx.dryjanski@intel.com>
remove buffer ops from waves.c this is a continuation of changes from commit 4a03699 Signed-off-by: Tobiasz Dryjanski <tobiaszx.dryjanski@intel.com>
remove buffer ops from probe.c this is a continuation of changes from commit 4a03699 Signed-off-by: Tobiasz Dryjanski <tobiaszx.dryjanski@intel.com>
remove buffer ops from selector.c this is a continuation of changes from commit 4a03699 Signed-off-by: Tobiasz Dryjanski <tobiaszx.dryjanski@intel.com>
remove buffer ops from tone.c this is a continuation of changes from commit 4a03699 Signed-off-by: Tobiasz Dryjanski <tobiaszx.dryjanski@intel.com>
remove buffer ops from tdfb.c this is a continuation of changes from commit 4a03699 Signed-off-by: Tobiasz Dryjanski <tobiaszx.dryjanski@intel.com>
tobonex
force-pushed
the
buffer_acquire_removal_5
branch
from
September 20, 2023 15:57
f53ed83 to
e22321f
Compare
lyakh
approved these changes
Sep 21, 2023
singalsu
approved these changes
Sep 21, 2023
marcinszkudlinski
approved these changes
Sep 21, 2023
Member
|
@tobonex @marcinszkudlinski is this next in the series ? I dont think we have any dependecies ? |
Contributor
Author
Yes, it's this one. |
Member
|
@tobonex ok, lets get this in the daily test tomorrrow and if all good we can move on to part 6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is step 7 of implementation of #8006
This PR is a result of splitting #8106 into parts.
Remove usage of buffer_acquire and buffer_release from a number of files.
next part: #8221