Anchor a civil date and time of day to an instant. - #16
Merged
Conversation
A LocalDate and a TimeOfDay are both civil values, and the library could only project the other way, from an instant to a local date. The timezone is what closes the round trip. Daylight saving leaves two civil times that are not one-to-one with the timeline, and both resolve deterministically instead of raising. A time inside the spring-forward gap maps to the same instant as the first civil time after the gap, and a time inside the fall-back overlap maps to the earlier of the two. Raising would break a caller iterating a slot grid across a transition, which is the case this method exists for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A LocalDate and a TimeOfDay are both civil values, and the library could only project the other way, from an instant to a local date. The timezone is what closes the round trip.
Daylight saving leaves two civil times that are not one-to-one with the timeline, and both resolve deterministically instead of raising. A time inside the spring-forward gap maps to the same instant as the first civil time after the gap, and a time inside the fall-back overlap maps to the earlier of the two. Raising would break a caller iterating a slot grid across a transition, which is the case this method exists for.
Summary
What this pull request does.
Related issue
Closes #...
Checklist
composer reviewpasses.composer testspasses.