Skip to content

fix(tmux_cmd): remove only trailing new lines in stdout - #405

Merged
tony merged 5 commits into
tmux-python:masterfrom
rockandska:fix/space_capture_pane
Aug 28, 2022
Merged

fix(tmux_cmd): remove only trailing new lines in stdout#405
tony merged 5 commits into
tmux-python:masterfrom
rockandska:fix/space_capture_pane

Conversation

@rockandska

Copy link
Copy Markdown
Contributor

Close #402

Seems the branch v0.8x did not exist anymore to backport this change.

@CLAassistant

CLAassistant commented Aug 22, 2022

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@rockandska
rockandska force-pushed the fix/space_capture_pane branch from 162eaf9 to 0995d26 Compare August 22, 2022 15:33
Comment thread libtmux/session.py Outdated
@rockandska
rockandska force-pushed the fix/space_capture_pane branch from 94b461d to 269c1d7 Compare August 23, 2022 08:10
@codecov

codecov Bot commented Aug 28, 2022

Copy link
Copy Markdown

Codecov Report

Merging #405 (16cb0e7) into master (94f507e) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   88.63%   88.74%   +0.11%     
==========================================
  Files          18       18              
  Lines        1865     1875      +10     
==========================================
+ Hits         1653     1664      +11     
+ Misses        212      211       -1     
Impacted Files Coverage Δ
libtmux/session.py 83.05% <ø> (+0.56%) ⬆️
libtmux/common.py 86.93% <100.00%> (+0.05%) ⬆️
tests/test_pane.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rockandska
rockandska force-pushed the fix/space_capture_pane branch from 269c1d7 to 4c48599 Compare August 28, 2022 16:50
Comment thread libtmux/common.py Outdated
Co-authored-by: Tony Narlock <tony@git-pull.com>
@tony
tony force-pushed the fix/space_capture_pane branch from 4a183d8 to 2346df4 Compare August 28, 2022 17:44
@tony
tony merged commit 6d3c49a into tmux-python:master Aug 28, 2022
@tony

tony commented Aug 28, 2022

Copy link
Copy Markdown
Member

@rockandska Since this could be considered breaking behavior (-ish), I am going to release this under v0.15.0a0 for you to test

Standby !

@tony

tony commented Aug 28, 2022

Copy link
Copy Markdown
Member

@rockandska

v0.15.0a0: GitHub release, git tag, PyPI package

pip install libtmux==0.15.0a0

@rockandska
rockandska deleted the fix/space_capture_pane branch August 28, 2022 18:17
@tony

tony commented Sep 10, 2022

Copy link
Copy Markdown
Member

Live in v0.15.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tmux_cmd remove empty lines when it should not

3 participants