Country selection - select by keyboard #2540 - #309
Merged
RishiRajSahu merged 5 commits intoJan 24, 2019
Conversation
Country selection - select by keyboard #2540
Country selection dropdown should not have horizontal scroll
fix fail select when search by key #2759
fix key up/down bound issue
maxceem
approved these changes
Jan 24, 2019
maxceem
left a comment
maxceem
left a comment
Collaborator
There was a problem hiding this comment.
Works great, thank you @suppermancool
Collaborator
|
@RishiRajSahu this PR solves this issue for Connect App and Accounts app https://github.com/appirio-tech/connect-app/issues/2540 PR in Connect App and this PR could be merged independently and they don't break anything if not merged together. But this feature will work in the Connect App and Accounts app after this PR merged. |
|
thanks @maxceem and @suppermancool for fixing the issue. Merging it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Country selection - select by keyboard #2540