Wizard redesign - Checkboxes and radio buttons with optional description and price (without design update) - #310
Merged
vikasrohit merged 5 commits intoMar 8, 2019
Conversation
…d redesign - Controls new design + fix to format prices with comma
maxceem
changed the title
…d - Disabled condition
…cted on the value update)
…other Formzy controls
|
@maxceem can we merge this PR safely without affecting behaviour of current components? I mean if we merge it today and do a production deploy afterwards, would it cause any troubles with the way the form elements are rendered currently on production? |
Collaborator
Author
|
@vikasrohit We only added new features but didn't break any existent features so this PR should be safe. |
|
Okay. I would merge it after today's release. Thanks for the update. |
|
merging the PR @maxceem @RishiRajSahu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
winning submission from challenge 30083737 - Topcoder Connect - Wizard redesign - Controls new design
This PR implements a part of form redesign which is now in https://github.com/appirio-tech/connect-app/tree/feature/form-redesign
After this PR is merged, we have to update dependency in connect app branch
feature/form-redesign, to point back toappirio-tech/react-components#feature/connectv2instead ofmaxceem/react-components#feature/connectv2-form-redesign