Fix for issue# 2857 on connect-app - #313
Merged
RishiRajSahu merged 3 commits intoMar 5, 2019
Merged
Conversation
akumar1503
commented
Feb 26, 2019
akumar1503
commented
- Bottom link is now clickable in WizardRight.
- Continue button fix in RegistrationScreen, it's not required to click the "I agree to receive other communications from Topcoder." checkbox.
- removed + sign requirement in phone numbers in Formsy.PhoneInput.
…egistrationScreen and remove + sign requirement in phone numbers in Formsy.PhoneInput
maxceem
requested changes
Feb 27, 2019
maxceem
left a comment
maxceem
left a comment
Collaborator
There was a problem hiding this comment.
Everything works good @akumar1503 .
Only one thing, could you please return adding + when we choose the county code in the dropdown.
We don't require entering + by users, but we still want to add + when we choose the country code.
Author
|
@maxceem done. |
Author
|
added minor correction, done now. |
maxceem
requested changes
Feb 28, 2019
maxceem
left a comment
maxceem
left a comment
Collaborator
There was a problem hiding this comment.
Works good!
Thank you @akumar1503
Collaborator
|
@RishiRajSahu I've tested this PR to cover 3 issues listed here https://github.com/appirio-tech/connect-app/issues/2857 It works good for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.