Solution for avoiding css conflicts especially with name of container. - #80
Merged
Conversation
Contributor
|
I have no problem with that naming pattern. I think though, that we should move away from webpack extension resolver altogether, since it is incompatible with the default node require system, and therefore doesn't play well with other systems like Mocha. |
Author
|
Thanks @aselbie However, I didn't get the point of extension resolver and its relevance to this change. Can you please elaborate more on this? |
Contributor
|
I was wondering the same :) |
Author
|
Merged for now. Please let me know if you face any problems with after this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nlitwin @aselbie @samsep do you see any issue with this renaming of css class name? container is very generic class and is probable for css overriding in the calling app. e.g. in tc-site, this class is causing displacement of loading icon when showing nav bar in tc-site.