fix: Add an update sub-command the @trigger.dev/cli that updates all @trigger.dev/* packages #317
Conversation
🦋 Changeset detectedLatest commit: 4b64c2d The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I've tested this with both npm & pnpm as well. @ologbonowiwi would you like to confirm as well? |
wesleymatosdev
left a comment
There was a problem hiding this comment.
Tested here and it works locally
|
Thanks for the confirmation! @ericallam Can you take a look at this now that we've confirmed working of this? |
matt-aitken
left a comment
There was a problem hiding this comment.
This is mostly there. But there's an issue with how you're evaluating whether packages are the same or not.
You can test CLI changes like this by following from line 123 in the Contributions guide.
|
@matt-aitken @ericallam Did you get a chance to look at this one? |
|
@rishi-raj-jain the code looks good, but I think we should use this package (recommended by another developer): https://www.npmjs.com/package/npm-check-updates This would massively simplify the code here and will be more reliable as that package has a lot of contributors and high usage. You can see how it's used as a package at the bottom of the readme. You can specify wildcards to get all the I'll tip you generously if you make this change because we've messed you around a bit here. Sorry about that. |
|
Sure, I'll be on it. Appreciate your kindness |
|
Hey @matt-aitken, I just took a look at the suggested package. For this won't the user need to install the npm-check-updates package on their device globally? I mean we can do it with another exec as well but it seems intrusive. |
|
Happy to implement with the package suggested if you want me to. I'm fine with that as well. Just lmk. |
|
@rishi-raj-jain You can use So you just need to add |
|
Thanks for pointing me in that direction! This is ready for review. |
|
This is looking good! Can you please leave a comment on this PR the steps you've taken to test this change? |
|
Let me attach the whole reproduction video. I tried the whole thing in a seperate project. |
|
Video: https://a.storyblok.com/f/117912/x/7b8a5ad330/screen-recording-2023-08-22-at-2-51-36-pm.mp4
|
|
Can you use our guide for testing CLI changes here: https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md#testing-cli-changes |
|
Done, it worked! Here's the whole of video of the same: Screen.Recording.2023-08-22.at.3.16.27.PM.mp4 |
|
Thanks for merging the PR. Just saying that in that comment, I was told that I'd get a generous tip. Would be good to hear from you regarding the same. |
|
/tip $100 |
|
🎉🎈 @rishi-raj-jain has been awarded $100! 🎈🎊 |
|
Thank you so much for considering that, @ericallam! 🙏🏻 |

Resolves #166
/claim #166