Recommend idiomatic identifiers for invalid pin labels - #2976
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
V3_3,V5, and related identifiers for common voltage pin labels such as3.3V,+3V3, and+5VWhy
tscircuit pin identifiers only support letters, numbers, and underscores. Common module labels containing
+or.were filtered out, and schematic arrangements could then fail with an opaque error. This can produce empty/black footprint renders when the component never finishes creating.The new guidance maps common voltage forms to exact idiomatic identifiers, for example:
3.3Vor+3V3->V3_3+5V->V5The actual voltage metadata remains unchanged; only the pin identifier recommendation is normalized.
Verification
bun test tests/components/normal-components/chip-invalid-pin.test.tsxbun run buildbunx tsc --noEmit