Preserve literal silkscreen labels from footprinter strings - #2980
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Preserve literal
pcb_silkscreen_text.textvalues generated by the explicitsilkscreenlabel(...)footprinter option when importing a footprinter result into core. The importer resolves the reference placeholders{REF},{NAME}, and{REFERENCE}to the component name, while custom text such asXIAO RP2040remains unchanged. Other imported footprint text keeps the existing component-name fallback.This lets footprinter strings provide a module title while retaining the normal component-name behavior for reference placeholders.
Validation
bun test tests/utils/createComponentsFromCircuitJson/footprinter-silkscreen-label.test.tsxbun run buildbunx tsc --noEmit