ci: cache prek instead of pre-commit in copier-template-tester#60
Merged
Conversation
The rendered project switched from pre-commit to prek in e397011, but the copier-template-tester job still cached ~/.cache/pre-commit. That directory is never created during `uv run ctt` (the rendered projects' tasks run prek, which caches under ~/.cache/prek), so the cache save found nothing and actions/cache warned about a non-existent path. Point the cache at ~/.cache/prek and key it on the rendered pre-commit config template. Drop the top-level .pre-commit-config.yaml from the key: it governs the separate pre-commit job, not the hooks prek installs in rendered projects. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VnSA7mKDr3hkDCxZeUvFZY
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider using $HOME/.cache/prek instead of ~/.cache/prek in the cache path for better portability and to avoid any issues with shell expansion in different contexts.
- It may be worth including the prek version (or a relevant lockfile) in the cache key to avoid reusing incompatible caches across prek upgrades.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider using $HOME/.cache/prek instead of ~/.cache/prek in the cache path for better portability and to avoid any issues with shell expansion in different contexts.
- It may be worth including the prek version (or a relevant lockfile) in the cache key to avoid reusing incompatible caches across prek upgrades.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rendered project switched from pre-commit to prek in e397011, but the copier-template-tester job still cached ~/.cache/pre-commit. That directory is never created during
uv run ctt(the rendered projects' tasks run prek, which caches under ~/.cache/prek), so the cache save found nothing and actions/cache warned about a non-existent path.Point the cache at ~/.cache/prek and key it on the rendered pre-commit config template. Drop the top-level .pre-commit-config.yaml from the key: it governs the separate pre-commit job, not the hooks prek installs in rendered projects.
Claude-Session: https://claude.ai/code/session_01VnSA7mKDr3hkDCxZeUvFZY