Skip to content

ci: cache prek instead of pre-commit in copier-template-tester#60

Merged
tsvikas merged 1 commit into
mainfrom
fix-ctt-prek-cache
Jul 14, 2026
Merged

ci: cache prek instead of pre-commit in copier-template-tester#60
tsvikas merged 1 commit into
mainfrom
fix-ctt-prek-cache

Conversation

@tsvikas

@tsvikas tsvikas commented Jul 14, 2026

Copy link
Copy Markdown
Owner

The rendered project switched from pre-commit to prek in e397011, but the copier-template-tester job still cached ~/.cache/pre-commit. That directory is never created during uv run ctt (the rendered projects' tasks run prek, which caches under ~/.cache/prek), so the cache save found nothing and actions/cache warned about a non-existent path.

Point the cache at ~/.cache/prek and key it on the rendered pre-commit config template. Drop the top-level .pre-commit-config.yaml from the key: it governs the separate pre-commit job, not the hooks prek installs in rendered projects.

Claude-Session: https://claude.ai/code/session_01VnSA7mKDr3hkDCxZeUvFZY

The rendered project switched from pre-commit to prek in e397011, but the
copier-template-tester job still cached ~/.cache/pre-commit. That directory
is never created during `uv run ctt` (the rendered projects' tasks run prek,
which caches under ~/.cache/prek), so the cache save found nothing and
actions/cache warned about a non-existent path.

Point the cache at ~/.cache/prek and key it on the rendered pre-commit config
template. Drop the top-level .pre-commit-config.yaml from the key: it governs
the separate pre-commit job, not the hooks prek installs in rendered projects.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VnSA7mKDr3hkDCxZeUvFZY

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider using $HOME/.cache/prek instead of ~/.cache/prek in the cache path for better portability and to avoid any issues with shell expansion in different contexts.
  • It may be worth including the prek version (or a relevant lockfile) in the cache key to avoid reusing incompatible caches across prek upgrades.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider using $HOME/.cache/prek instead of ~/.cache/prek in the cache path for better portability and to avoid any issues with shell expansion in different contexts.
- It may be worth including the prek version (or a relevant lockfile) in the cache key to avoid reusing incompatible caches across prek upgrades.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@tsvikas
tsvikas merged commit f4fda7d into main Jul 14, 2026
5 checks passed
@tsvikas
tsvikas deleted the fix-ctt-prek-cache branch July 14, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant