Added Build Tool Plug-ins support

[BarredEwe]

Short description 📝

This is a continuation of #733, to support Build Tool Plug-ins. (Thanks to @technocidal)

Solution 📦

Added the difference between plugins and dependencies. Added correction of temporary identifiers for plugins.

Implementation 👩‍💻👨‍💻

• Now we can separate the Dependency from plug-in:

// file: XCSwiftPackageProductDependency

/// Is it a Plugin.
var isPlugin: Bool {
    productName.hasPrefix("plugin:")
}

• After separation, we need to fix TEMP identifiers:

// file: ReferenceGenerator

// Build Tool Plug-ins
target.dependencies.forEach {
    guard let product = $0.product, product.isPlugin else { return }

    var identifiers = identifiers
    identifiers.append(product.productName)
    fixReference(for: product, identifiers: identifiers)
}

• And of course, some tests for classes: ReferenceGenerator, XCSwiftPackageProductDependency

[netlify]

✅ Deploy Preview for xcodeproj ready!

Name	Link
🔨 Latest commit	371857a
🔍 Latest deploy log	https://app.netlify.com/sites/xcodeproj/deploys/64b1291a8cc6fa0008da27f7
😎 Deploy Preview	https://deploy-preview-784--xcodeproj.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[BarredEwe]

You can try how it works with XcodeGen 😊: Usage

[VVannafly]

cool

[kwridan]

Thanks for picking this up @BarredEwe 🙏

I ran a small test locally by creating a project with a build plugin in Xcode then attempted to read / write the project using this PR and noticed the following diffs:

(left is vanilla Xcode, right is the one from XcodeProj)

I believe the productName needs to remove the plugin: prefix (and use that to infer isPlugin and only add it back when serialising productName in the XCSwiftPackageProductDependency section.

[BarredEwe]

@kwridan Thanks for reviewing 😊
I noticed it too, but I didn't pay attention. I have already corrected and posted the changes.

Here is what is generated now when adding a plugin:

dependencies = (
    975D5D662A613C2200317422 /* PBXTargetDependency */,
);

975D5D662A613C2200317422 /* PBXTargetDependency */ = {
    isa = PBXTargetDependency;
    productRef = 975D5D652A613C2200317422 /* SomePluginName */;
};

975D5D652A613C2200317422 /* SomePluginName */ = {
    isa = XCSwiftPackageProductDependency;
    productName = "plugin:SomePluginName";
};

As far as I've been able to verify, this is exactly the same as what Xcode generates.

[kwridan]

Thanks for the updates @BarredEwe

[kwridan]

thanks @BarredEwe

[BarredEwe]

@pepicrft @yonaskolb Could you please review?)

[iteracticman]

Could someone from the core team (or whoever can make the Merge button turn green) please review this?

[yonaskolb]

I haven't been in this codebase in a while, but looks ok to me. Thanks @BarredEwe

[mgray88]

Is this functionality available in Tuist? I can't seem to find any documentation

Eta: Specifically I'm trying to integrate Cuckoo via SPM instead of cocoapods

[luispadron]

@mgray88 XcodeProj is used by Tuist but its not the only tool that uses this project. I'd open an issue in the Tuist repository