Fix explicit flow grains script run - #274
Merged
lmoresi merged 1 commit intoJun 24, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates docs/examples/porous_flow/advanced/Ex_Explicit_Flow_Grains.py so that the explicit grain-flow example runs correctly as a plain Python script.
The example failed during pipemesh.write_timestep(...) with:
AttributeError: 'NoneType' object has no attribute 'name'
The gmsh-created mesh did not have an explicit coordinate system, so self.CoordinateSystemType was None when the mesh writer serialized coordinate-system metadata. This PR sets:
coordinate_system_type=uw.coordinates.CoordinateSystemType.CARTESIAN
in the uw.discretisation.Mesh(...) constructor.
The example also imported PyVista during a terminal run. The visualization blocks are now guarded with a notebook check, so the solve, timestep writing, porosity calculation, and swarm advection path run without optional notebook visualization dependencies.
The gmsh geometry, boundary tags, Stokes setup, pressure projection, swarm advection, and output logic are otherwise unchanged.
Tested with:
pixi run python docs/examples/porous_flow/advanced/Ex_Explicit_Flow_Grains.py
Result:
Explicit grain flow example complete: 556 steps