Update solver template DDT imports - #474
Open
ss2098 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
The failing test_uw3 import-smoke check appears to fail during MPI/UCX initialization before this PR change is reached: UCX ERROR mana_0 ... failed to create UD QP This PR only updates solver_template.py DDT import/type-hint names. Local validation passed with: pixi run python src/underworld3/systems/solver_template.py I do not have permission to rerun the upstream workflow, so a maintainer rerun may be needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates src/underworld3/systems/solver_template.py to use the current DDT class names exported by underworld3.systems.ddt.
The old names SemiLagrangian_DDt, Lagrangian_DDt, and Eulerian_DDt are no longer exported. The current public names are SemiLagrangian, Lagrangian, and Eulerian.
This updates the import and matching type hints only.
Validation: