Add input checks to stagnant lid comparison plot - #481
Open
ss2098 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
The failing test_uw3 import-smoke check appears to fail during MPI/UCX initialization before this PR change is reached: UCX ERROR mana_0 ... failed to create UD QP This PR only adds preflight input checks to scripts/stagnant_lid_adapt_compare_plot.py. Local validation passed with: python -m py_compile scripts/stagnant_lid_adapt_compare_plot.py With missing local checkpoint inputs, the script now exits cleanly after listing the missing files instead of failing later with a PETSc/HDF5 traceback. I do not have permission to rerun the upstream workflow, so a maintainer rerun may be needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a preflight input check to scripts/stagnant_lid_adapt_compare_plot.py.
The script is a post-processing plot script and expects existing stagnant-lid checkpoint outputs. Previously, if the hard-coded checkpoint directories or files were missing, PETSc/HDF5 failed later with a low-level H5Fopen error.
This update checks for the required mesh and T checkpoint files before loading them and prints a clear message explaining which inputs are missing and that the user should run/copy the checkpoint outputs first or update U_DIR/A_DIR and U_STEM/A_STEM.
This does not change solver internals or checkpoint loading behavior when the required files exist.
Validation:
With missing local checkpoint files, the script now exits cleanly after listing the missing required inputs instead of failing with a PETSc/HDF5 traceback.