feat: store queryInterval timestamp in a separate status field#119
Merged
Conversation
Follow-up to #118, addressing customer feedback on the (still unreleased) queryInterval feature. Previously the last successful query timestamp was appended as an extra {lastQueryTime: ...} element to the result list at the status target, which polluted a list that frequently drives downstream composed resources. Store it instead in a separate status.lastQueryTimestamps map keyed by target, leaving the result a clean list. The example XRD status schema gains a lastQueryTimestamps field, and the code drops the array/map append + extract helpers. The combined-flags warning already landed with #118; only its test is updated here to the new shape. Signed-off-by: Yury Tsarev <yury@upbound.io>
ytsarev
force-pushed
the
feat/query-interval-timestamps
branch
from
July 20, 2026 21:04
a4ea72c to
24d52e0
Compare
ytsarev
changed the title
kaessert
approved these changes
Jul 20, 2026
jakubramut
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #118 (customer feedback) on the still-unreleased
queryIntervalfeature.Previously the last-query timestamp was appended as an extra element to the result list at the status target, polluting a list that often drives downstream composed resources. It is now stored in a separate
status.lastQueryTimestampsmap, keyed by target, leaving the result a clean list:The example XRD gains a
lastQueryTimestampsstatus field.queryIntervalis rc-only, so no released behavior changes. The combined-flags warning already landed in #118 and is unchanged here.Testing
go build/test/vetandgolangci-lintgreen;crossplane rendersmoke test; kind + Crossplane 2.3.3 e2e withv0.7.0-rc4,queryInterval: "2m":validatedUserslist +lastQueryTimestamps.validatedUsersrecordedFunctionSkip/IntervalLimit, list unchanged