Add Brunei (ms-BN) mobile phone number validation - #2820
Open
snehal242005 wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2820 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2587 2587
Branches 656 656
=========================================
Hits 2587 2587 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tux-tn
requested changes
Jul 28, 2026
tux-tn
left a comment
Member
There was a problem hiding this comment.
Thank you for your PR.
The regex currently accepts only 7 and 8 prefixes:
/^(\+?673)?[78]\d{6}$/AITI's numbering plan also assigns +673 228 XXXX and +673 229 XXXX to mobile services. Valid numbers such as +6732281234 are currently rejected. Please add the 228 and 229 ranges with corresponding fixtures/tests.
See the official ITU Document (https://www.itu.int/dms_pub/itu-t/oth/02/02/T020200001F0002PDFE.pdf), table 2-3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added mobile phone number validation for Brunei (locale:
ms-BN) as part of the ongoing effort in #1761 to add missing country validations.Brunei mobile numbers are 7 digits starting with 7 or 8, with an optional +673 country code prefix, per ITU numbering plan references.
Checklist