Skip to content

chore(benches): Add benchmarks for the OTLP codecs#25923

Merged
bruceg merged 2 commits into
masterfrom
bruceg/otlp-codec-benchmark
Jul 22, 2026
Merged

chore(benches): Add benchmarks for the OTLP codecs#25923
bruceg merged 2 commits into
masterfrom
bruceg/otlp-codec-benchmark

Conversation

@bruceg

@bruceg bruceg commented Jul 22, 2026

Copy link
Copy Markdown
Member

Summary

Just what it says on the tin.

This also moves the codecs benchmarks into lib/codecs in order to reduce the development cycle time when iterating on performance improvements in that area. The codecs benchmarks do not use any part of the main vector library, but by being located in the top-level benches directory they depend on it, increasing the linker/optimizer time to build it by a large amount.

Vector configuration

N/A

How did you test this PR?

Change Type

  • Bug fix
  • New feature
  • Dependencies
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • make fmt
      • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
      • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.

The `codecs` benchmarks do not use any part of the main `vector` library, but by
being located in the top-level `benches` directory they depend on it, increasing
the linker/optimizer time to build it by a large amount. Moving them into
`lib/codecs` reduces the cycle time when working on performance there.
@bruceg
bruceg requested a review from petere-datadog July 22, 2026 17:19
@bruceg
bruceg requested a review from a team as a code owner July 22, 2026 17:19
@bruceg bruceg added type: tech debt A code change that does not add user value. domain: performance Anything related to Vector's performance domain: codecs Anything related to Vector's codecs (encoding/decoding) no-changelog Changes in this PR do not need user-facing explanations in the release changelog domain: opentelemetry labels Jul 22, 2026
@github-actions github-actions Bot removed the domain: codecs Anything related to Vector's codecs (encoding/decoding) label Jul 22, 2026
@bruceg
bruceg force-pushed the bruceg/otlp-codec-benchmark branch from 9700753 to e9492b3 Compare July 22, 2026 17:37
@bruceg
bruceg enabled auto-merge July 22, 2026 17:44
@bruceg
bruceg added this pull request to the merge queue Jul 22, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 970075354b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/codecs/Cargo.toml
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 22, 2026
@bruceg
bruceg added this pull request to the merge queue Jul 22, 2026
Merged via the queue into master with commit f07c508 Jul 22, 2026
127 checks passed
@bruceg
bruceg deleted the bruceg/otlp-codec-benchmark branch July 22, 2026 20:15
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 22, 2026
@bruceg bruceg added the domain: codecs Anything related to Vector's codecs (encoding/decoding) label Jul 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

domain: codecs Anything related to Vector's codecs (encoding/decoding) domain: opentelemetry domain: performance Anything related to Vector's performance no-changelog Changes in this PR do not need user-facing explanations in the release changelog type: tech debt A code change that does not add user value.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants